Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and apply linter #66

Merged
merged 46 commits into from
Oct 23, 2023
Merged

Add and apply linter #66

merged 46 commits into from
Oct 23, 2023

Conversation

wederbn
Copy link
Collaborator

@wederbn wederbn commented Jun 15, 2023

No description provided.

@wederbn wederbn requested a review from mbeisel June 15, 2023 12:20
@wederbn
Fix name in Github workflow
0fd5db2
@wederbn
Enable unused variable linting rule
dd1fabb
@wederbn
Run prettier
d2577e6
@wederbn
Enable unnecessary espace rule
c0f4696
@wederbn
Add .eslintignore
25df57a
@wederbn
Adapt path to public folder
1645c45
@wederbn
Update ignore rules for linters
9a22188
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
5fd8cd4
@wederbn
Lint changes after merging master
cb38a43
@wederbn
Start fixing Readme
d081013
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
606b709
@wederbn
Lint changes from merge
4d3602d
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
60444dc
@wederbn
Lint master merge
452e3a3
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
85c3736
@wederbn
Lint changes after merge with origin/master
65f4136
@wederbn
Replace renderer with correct file
dbc8ef8
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
25b38d5
@wederbn
Lint changes
a28f6dd
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
4e14fe7
wederbn and others added 8 commits August 25, 2023 13:08
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
82c83da
@wederbn
Lint changes
c7bbd8f
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
b638937
@wederbn
Run linter
35c044c
@wederbn
Fix lint error
20c017a
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
3680608
@wederbn
Add badges to readme
0b3b030
@LaviniaStiliadou @SharonNaemi @mbeisel
New diagram dialog (#89)
4d42f49 
* dialog for new diagram, isExecutable to true

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* adjust label for canceling dialog

---------

Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>
@wederbn wederbn linked an issue Oct 2, 2023 that may be closed by this pull request
Dialog when openening new diagram #75
Closed
@LaviniaStiliadou
Fix plugin handling (#87)
9a3c9be 
* fix plugin handling

* fix lint
@wederbn wederbn linked an issue Oct 2, 2023 that may be closed by this pull request
Disabling Plugins via EnvironmentVariables does not seem to work #80
Closed
LaviniaStiliadou
LaviniaStiliadou approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@LaviniaStiliadou LaviniaStiliadou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaviniaStiliadou LaviniaStiliadou merged commit 17cc92f into master Oct 23, 2023
2 checks passed
@LaviniaStiliadou LaviniaStiliadou deleted the feature/linter branch October 23, 2023 14:29
@wederbn wederbn restored the feature/linter branch October 24, 2023 08:33
@wederbn wederbn deleted the feature/linter branch October 24, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaviniaStiliadou LaviniaStiliadou LaviniaStiliadou approved these changes

@mbeisel mbeisel Awaiting requested review from mbeisel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling Plugins via EnvironmentVariables does not seem to work Dialog when openening new diagram
3 participants
@wederbn @LaviniaStiliadou @mbeisel